[
https://issues.apache.org/jira/browse/MAPREDUCE-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331177#comment-16331177
]
Robert Kanter edited comment on MAPREDUCE-6995 at 1/18/18 8:41 PM:
-------------------------------------------------------------------
Some minor comments:
# "The tool then returns a suggestion how to set ..." should be "The tool then
returns a suggestion *of* how to set ..."
# "Defaults to the default filesystem set by fs.defaultFS." - fs.defaultFs
should have the ` to make it monospaced.
# Can you double check that paths starting with just {{hdfs:/}} work? (as
opposed to {{hdfs://}})
# The explanations of the arguments (e.g. {{-initialReplication}}) should have
the ` around the argument names to make them monospaced.
# "If this value is set to low like a constant 10 ..." is more clear and
consistent with the next sentence if it's written as "If this is set to a low
value like 10 ..."
# The description for {{-acceptableReplication}} should say what it actually
does, not just the requirements for it. Something like "The tool will wait
until the tarball has been replicated this number of times before exiting."
# "The frameworkuploader tool has the following arguments to control, which
jars end up in the framework tarball:" should not have the comma.
# "This is an input classpath that is iterated through. jars files found will
be added to the tarball. Defaults to the classpath." should be "This is *the*
input classpath to source jar files from to add to the tarball. *It defaults to
the classpath as returned by the {{hadoop classpath}} command.*"
# "This is a comma separated regex array to filter the jar file names to
include from the class path." should be "This is a comma separated regex array
to filter the jar file names to *exclude* from the class path."
# It might be good to give an example of {{-nosymlink}} as it's not clear just
from the description of what this does. Something like "For example,
{{/a/foo.jar}} and a symlink {{/a/bar.jar}} that points to {{/a/foo.jar}} would
normally add foo.jar and bar.jar to the tarball as separate files despite them
actually being the same file. This flag would make the tool exclude
{{/a/bar.jar}} so only one copy of the file is added."
# In the {{testExplicitFilesystem}} test, we should have a similar test where
{{-target}} and {{FS_DEFAULT_NAME_KEY}} have different filesystems.
# The {{frameworkupload}} command should be added to the MapredCommands.md file
was (Author: rkanter):
Some minor comments:
# "The tool then returns a suggestion how to set ..." should be "The tool then
returns a suggestion *of* how to set ..."
# "Defaults to the default filesystem set by fs.defaultFS." - fs.defaultFs
should have the ` to make it monospaced.
# Can you double check that paths starting with just {{hdfs:/}} work? (as
opposed to {{hdfs://}})
# The explanations of the arguments (e.g. {{-initialReplication}}) should have
the ` around the argument names to make them monospaced.
# "If this value is set to low like a constant 10 ..." is more clear and
consistent with the next sentence if it's written as "If this is set to a low
value like 10 ..."
# The description for {{-acceptableReplication}} should say what it actually
does, not just the requirements for it. Something like "The tool will wait
until the tarball has been replicated this number of times before exiting."
# "The frameworkuploader tool has the following arguments to control, which
jars end up in the framework tarball:" should not have the comma.
# "This is an input classpath that is iterated through. jars files found will
be added to the tarball. Defaults to the classpath." should be "This is *the*
input classpath to source jar files from to add to the tarball. *It defaults to
the classpath as returned by the {{hadoop classpath}} command.*"
# "This is a comma separated regex array to filter the jar file names to
include from the class path." should be "This is a comma separated regex array
to filter the jar file names to *exclude* from the class path."
# It might be good to give an example of {{-nosymlink}} as it's not clear just
from the description of what this does. Something like "For example,
{{/a/foo.jar}} and a symlink {{/a/bar.jar}} that points to {{/a/foo.jar}} would
normally add foo.jar and bar.jar to the tarball as separate files despite them
actually being the same file. This flag would make the tool exclude
{{/a/bar.jar}} so only one copy of the file is added."
# In the {{testExplicitFilesystem}} test, we should have a similar test where
{{-target}} and {{FS_DEFAULT_NAME_KEY}} have different filesystems.
> Uploader tool for Distributed Cache Deploy documentation
> --------------------------------------------------------
>
> Key: MAPREDUCE-6995
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6995
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Priority: Major
> Attachments: MAPREDUCE-6995.000.patch, MAPREDUCE-6995.001.patch,
> MAPREDUCE-6995.002.patch, MAPREDUCE-6995.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
