[ https://issues.apache.org/jira/browse/MAPREDUCE-7064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398694#comment-16398694 ]
Jason Lowe commented on MAPREDUCE-7064: --------------------------------------- Thanks for updating the patch! Just noticed one more thing I missed in the first review. There's one test block in testMRAppHistoryForTAFailedInAssigned that didn't close the app like all the other ones did. Intentional? {code} // test TA_FAILMSG for reduce app = new FailingAttemptsDuringAssignedMRApp(0, 1, TaskAttemptEventType.TA_FAILMSG); testTaskAttemptAssignedFailHistory(app); // test TA_FAILMSG_BY_CLIENT for map app = new FailingAttemptsDuringAssignedMRApp(1, 0, TaskAttemptEventType.TA_FAILMSG_BY_CLIENT); {code} > Flaky test TestTaskAttempt#testReducerCustomResourceTypes > --------------------------------------------------------- > > Key: MAPREDUCE-7064 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7064 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, test > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Major > Attachments: MAPREDUCE-7064-001.patch, MAPREDUCE-7064-002.patch > > > The test {{TestTaskAttempt#testReducerCustomResourceType}} can occasionally > fail with the following error: > {noformat} > org.apache.hadoop.yarn.exceptions.ResourceNotFoundException: Unknown resource > 'a-custom-resource'. Known resources are [name: memory-mb, units: Mi, type: > COUNTABLE, value: 0, minimum allocation: 0, maximum allocation: > 9223372036854775807, name: vcores, units: , type: COUNTABLE, value: 0, > minimum allocation: 0, maximum allocation: 9223372036854775807] > at > org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt.createReduceTaskAttemptImplForTest(TestTaskAttempt.java:434) > at > org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt.testReducerCustomResourceTypes(TestTaskAttempt.java:1535) > {noformat} > The root cause seems to be an interference from previous tests that start > instance(s) of {{FailingAttemptsMRApp}} or > {{FailingAttemptsDuringAssignedMRApp}}. When I disabled these tests, > {{testReducerCustomResourceTypes}} always passed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org