Jason Lowe commented on MAPREDUCE-7069:

Thanks for updating the patch!  Looks like TestPipeApplication and 
TestMRIntermediateDataEncryption both exited abnormally.  I was not able to 
reproduce either failure locally with the patch applied.

In mapred-default.xml "UEnvironment" s/b "Environment".

The example added to the tutorial is missing the "-D" flag required to be in 
front of all of the example options.  These properties are not valid 
command-line options directly.

Nit: "alternateForm" confusd me as a parameter name to testAMStandardEnv at 
first, and the comment in the method body explaining what it did was key to 
understanding it.  Maybe "useSeparateEnvProps" or something similar would be a 
better parameter name?

Nit: It would be nice to have some whitespace between the unit test methods for 

I'm not sure the DockerContainers.md change is necessary.  We still support the 
old, single-property way to set a list of environment variables that doesn't 
contain commas in the values.  I'm not sure we need to make the example more 
complicated given the variable settings don't have commas and therefore would 
require the separate property form.

> Add ability to specify user environment variables individually
> --------------------------------------------------------------
>                 Key: MAPREDUCE-7069
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7069
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Jim Brennan
>            Assignee: Jim Brennan
>            Priority: Major
>         Attachments: MAPREDUCE-7069.001.patch, MAPREDUCE-7069.002.patch, 
> MAPREDUCE-7069.003.patch, MAPREDUCE-7069.004.patch, MAPREDUCE-7069.005.patch
> As reported in YARN-6830, it is currently not possible to specify an 
> environment variable that contains commas via {{mapreduce.map.env}}, 
> mapreduce.reduce.env, or {{mapreduce.admin.user.env}}.
> To address this, [~aw] proposed in [YARN-6830] that we add the ability to 
> specify environment variables individually:
> {quote}e.g, mapreduce.map.env.[foo]=bar gets turned into foo=bar
> {quote}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to