[
https://issues.apache.org/jira/browse/MAPREDUCE-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593651#comment-16593651
]
Haibo Chen commented on MAPREDUCE-6861:
---------------------------------------
Thanks [~zsiegl] for the patch. The patch looks good to me with minor comments.
1) The description of the RECORD_INFO can be "Metrics for Shuffle client"
instead of "Metrics for Shuffle Plugin"
2) TestShuffleClientMetrics.testCreate() can probably be renamed to
testShuffleMetricsTag() or the like.
3) "shuffleClientMetrics.threadBusy();" is not necessary as part of the act
step in the unit test given what the test is doing.
> Add metrics tags for ShuffleClientMetrics
> -----------------------------------------
>
> Key: MAPREDUCE-6861
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6861
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha1
> Reporter: Akira Ajisaka
> Assignee: Zoltan Siegl
> Priority: Major
> Labels: newbie++
> Attachments: MAPREDUCE-6861.00.patch, MAPREDUCE-6861.01.patch
>
>
> Metrics tags were unintentionally removed by MAPREDUCE-6526. Let's add them
> back.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
