[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646697#comment-16646697
 ] 

Jason Lowe commented on MAPREDUCE-7149:
---------------------------------------

Thanks for the patch!  Other than the whitespace nit, +1 lgtm.

> javadocs for FileInputFormat and OutputFormat to mention DT collection
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7149
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7149
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-7149-001.patch
>
>
> the fact that DTs are collected for a job in 
> {{FileInputFormat.listStatus(JobConf job)}}  and 
> {{OutputFormat.checkOutputSpecs}} is not something mentioned in the javadocs, 
> or that obvious when you look @ the API.
> Add a sentence to the javadocs of the relevant methods to make clear "the job 
> you pass in is altered; anyone subclassing needs call their superclass or do 
> something similar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to