[
https://issues.apache.org/jira/browse/MAPREDUCE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776492#comment-16776492
]
Hongyuan Li commented on MAPREDUCE-7186:
----------------------------------------
[~pbacsko], use {{IllegalArgumentException}} as the thrown exception, but no
junit test. Don't think it is good to create a new JobSubmiiterTest class just
to test whether the exception is thrown.
> JobSubmitter#checkSpecs doesn not handle the situation when reduceNums is set
> less than zero.
> ---------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7186
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7186
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Reporter: Hongyuan Li
> Priority: Minor
> Attachments: MAPREDUCE-7186-001.patch, MAPREDUCE-7186-002.patch,
> screenshot-1.png
>
>
> JobSubmitter#checkSpecs doesn not judge whether reduceNums is less than zero.
> {code:java}
> private void checkSpecs(Job job) throws ClassNotFoundException,
> InterruptedException, IOException {
> JobConf jConf = (JobConf)job.getConfiguration();
> // Check the output specification
> if (jConf.getNumReduceTasks() == 0 ?
> jConf.getUseNewMapper() : jConf.getUseNewReducer()) {
> org.apache.hadoop.mapreduce.OutputFormat<?, ?> output =
> ReflectionUtils.newInstance(job.getOutputFormatClass(),
> job.getConfiguration());
> output.checkOutputSpecs(job);
> } else {
> jConf.getOutputFormat().checkOutputSpecs(jtFs, jConf);
> }
> }
> {code}
> The code does handle the situation when reduceTaskNums is set to -1 or any
> other value less than zero.
> When use hive, the "mapred.reduce.tasks" has a default value -1.
>
> !screenshot-1.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
