[
https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783413#comment-16783413
]
Adam Antal edited comment on MAPREDUCE-7188 at 3/4/19 2:23 PM:
---------------------------------------------------------------
The patch LGTM (non-binding). Did you think about cleaning up the whole file a
bit?
Three items I would be happy about being done:
* remove default constructor (to me it looks like this is never used, but
needs to be proven)
* checkstyle: there are a few long (>80 char) lines, that could be broken up
(are there other checkstyle issues?)
* adding spaces in the ternary operator in {{combine()}}
was (Author: adam.antal):
The patch LGTM. Did you think about cleaning up the whole file a bit?
Three items I would be happy about being done:
* remove default constructor (to me it looks like this is never used, but
needs to be proven)
* checkstyle: there are a few long (>80 char) lines, that could be broken up
(are there other checkstyle issues?)
* adding spaces in the ternary operator in {{combine()}}
> [Clean-up] Remove NULL check before instanceof in TaskResult
> ------------------------------------------------------------
>
> Key: MAPREDUCE-7188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7188
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Shweta
> Priority: Minor
> Attachments: MAPREDUCE-7188.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
