[ https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821332#comment-16821332 ]
Steve Loughran commented on MAPREDUCE-7197: ------------------------------------------- assert j is now an approved format for tests; trunk is about 3.1.2; we probably need to backport that to the older branches > Fix order of actual and expected expression in assert statements > ---------------------------------------------------------------- > > Key: MAPREDUCE-7197 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 3.2.0 > Reporter: Adam Antal > Assignee: Adam Antal > Priority: Major > Attachments: old-approx-from-HADOOP-12693 > > > Fix order of actual and expected expression in assert statements which gives > misleading message when test case fails. Attached file has some of the places > where it is placed wrongly. > {code:java} > [ERROR] > testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService) > Time elapsed: 3.385 s <<< FAILURE! > java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but > was:<0> > {code} > For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be > used for new test cases which avoids such mistakes. > This is a follow-up Jira on the fix for the MR project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org