[
https://issues.apache.org/jira/browse/MAPREDUCE-7310?focusedWorklogId=521748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521748
]
ASF GitHub Bot logged work on MAPREDUCE-7310:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/20 15:46
Start Date: 08/Dec/20 15:46
Worklog Time Spent: 10m
Work Description: jiwq commented on pull request #2499:
URL: https://github.com/apache/hadoop/pull/2499#issuecomment-740700995
@aajisaka Can u help to review it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 521748)
Time Spent: 20m (was: 10m)
> Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-7310
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7310
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Zhengxi Li
> Priority: Minor
> Labels: pull-request-available
> Attachments: MAPREDUCE-7310.001.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The test
> '{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
> result in the second run failing due to `NullPointerException`shown in the
> following:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
> at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
> {noformat}
> The root cause of this is that running
> '{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
> entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
> entries in the '{{fileMap'}} are not cleaned up when the test is done,
> resulting in a NullPointerException in the second run as the stale
> object(added in the first run) in the 'fileMap' is accessed.
>
> PR link: https://github.com/apache/hadoop/pull/2499
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
