[
https://issues.apache.org/jira/browse/MAPREDUCE-7317?focusedWorklogId=542494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542494
]
ASF GitHub Bot logged work on MAPREDUCE-7317:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 22:58
Start Date: 26/Jan/21 22:58
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-767882952
Use DurationInfo in a try-with-resources; it will log start and end with
timings @ debug
```java
try (DurationInfo d = new DurationInfo(LOG,
"Aborting commit ID %s to path %s", uploadId, destKey)) {
writeOperations.abortMultipartCommit(destKey, uploadId);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 542494)
Time Spent: 1h 10m (was: 1h)
> Add latency information in FileOutputCommitter.mergePaths
> ---------------------------------------------------------
>
> Key: MAPREDUCE-7317
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7317
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Reporter: Jungtaek Lim
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We have been observed some occurrences of huge delay from file output
> committer V1, where file output committer V2 is not an option.
> While the root cause should have investigated on our side, there's another
> issue that there's insufficient information to debug. Most likely the huge
> delay comes from mergePaths, but the class only provides the "debug" log
> message to log the call itself with parameters, nothing else. mergePaths has
> been called recursively which is harder to trace how much latency specific
> directory takes to merge.
> It would be nice and not intrusive to add latency info in mergePath, so that
> we can see how much latency specific directory takes to merge, only when
> debug log is enabled.
> (Ideally it'd be nice if we can log warn message when the call takes huge
> time to process, but I don't have the proper threshold for the "huge time",
> so I'd avoid dealing with it altogether here.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
