[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313941#comment-17313941
 ] 

Brahma Reddy Battula commented on MAPREDUCE-7199:
-------------------------------------------------

Done.Committed to branch-3.3..

> HsJobsBlock reuse JobACLsManager for checkAccess
> ------------------------------------------------
>
>                 Key: MAPREDUCE-7199
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7199
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Bibin Chundatt
>            Assignee: Bilwa S T
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: MAPREDUCE-7199-001.patch, MAPREDUCE-7199.002.patch, 
> MAPREDUCE-7199.003.patch
>
>
> Reuse JobAclManager.checkAccess
> {code} 
>  private boolean checkAccess(String userName) {
>     if(!areAclsEnabled) {
>       return true;
>     }
>     // User could see its own job.
>     if (ugi.getShortUserName().equals(userName)) {
>       return true;
>     }
>     // Admin could also see all jobs
>     if (adminAclList != null && adminAclList.isUserAllowed(ugi)) {
>       return true;
>     }
>     return false;
>   }
> {code} 
> {code}
> jobACLsManager
>           .checkAccess(ugi, JobACL.VIEW_JOB, ..
>               new AccessControlList()))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to