[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Chen updated MAPREDUCE-7360:
---------------------------------
    Summary: Clean shared state pollution to avoid flaky tests  (was: Clean 
shared state pollution to avoid flaky tests in class TestMRAppMaster)

> Clean shared state pollution to avoid flaky tests
> -------------------------------------------------
>
>                 Key: MAPREDUCE-7360
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7360
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Yang Chen
>            Priority: Minor
>
> h2. What is the purpose of this change
> This PR is to clean shared state pollution between tests:
> {code:java}
> Test1: 
> org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier.testNotificationOnLastRetryShutdownWithRuntimeException
> Test2: 
> org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster.testMRAppMasterShutDownJob{code}
> Test1 can pollute the shared state with Test2, which can lead Test2 to fail 
> after running Test1. It may be better to clean state pollutions so that some 
> other tests won't fail in the future due to the shared state polluted by this 
> test.
> h2. Reproduce test failure
> First run Test1, then run Test2 in the same JVM
> h2. Expected result
> The tests should run successfully when multiple tests that use this state are 
> run in the same JVM.
> h2. Actual result
> Run Test1 and Test2, Test2 fails:
> {code:java}
> [ERROR] TestMRAppMaster.testMRAppMasterShutDownJob:530 Expected shutDownJob 
> to exit with status code of 0. expected:<0> but was:<1>{code}
> h2. Fix
> Reset FirstExitException at the start of Test2 to clean the pollution from 
> Test1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to