[
https://issues.apache.org/jira/browse/MAPREDUCE-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
CoolGuy updated MAPREDUCE-7362:
-------------------------------
Description:
Hello! I saw in your [contributing
guidelines|https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute]
that ??Please do not comment out code that is now obsolete: just remove it.??
However, I still witness some obsolete commented code in Java files like:
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerRequestor.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/TaskAttemptListenerImpl.java
I identified at least 100 commented code lines with a simple script.
Would you like to remove these commented code lines?
If so, I may help and open a pull request.
was:
Hello! I saw in your [contributing
guidelines|https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute]
that ??Please do not comment out code that is now obsolete: just remove it.??
However, I still witness some obsolete commented code in Java files like:
/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerRequestor.java
/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/TaskAttemptListenerImpl.java
Would you like to remove these commented codes?
If so, I may help and open a pull request.
> Removing obsolete commented code
> --------------------------------
>
> Key: MAPREDUCE-7362
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7362
> Project: Hadoop Map/Reduce
> Issue Type: Wish
> Reporter: CoolGuy
> Priority: Trivial
>
> Hello! I saw in your [contributing
> guidelines|https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute]
> that ??Please do not comment out code that is now obsolete: just remove it.??
> However, I still witness some obsolete commented code in Java files like:
> *
> hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerRequestor.java
> *
> hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
> *
> hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/TaskAttemptListenerImpl.java
> I identified at least 100 commented code lines with a simple script.
> Would you like to remove these commented code lines?
> If so, I may help and open a pull request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
