[
https://issues.apache.org/jira/browse/MAPREDUCE-7341?focusedWorklogId=741539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741539
]
ASF GitHub Bot logged work on MAPREDUCE-7341:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/22 11:02
Start Date: 15/Mar/22 11:02
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#2971:
URL: https://github.com/apache/hadoop/pull/2971#discussion_r826837442
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -219,6 +219,58 @@
<scope>test</scope>
</dependency>
+ <!--
+ the mapreduce-client-core module is compiled against for the
+ manifest committer support. It is not needed on the classpath
+ except when using this committer, so it only tagged as
+ "provided".
+ -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>test</scope>
Review comment:
this does mean that abfs-test jar does need it on the classpath.
if i declare this as provided, that will not be the case.
but it will then be a compile time dependency of the production code
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -219,6 +219,58 @@
<scope>test</scope>
</dependency>
+ <!--
+ the mapreduce-client-core module is compiled against for the
+ manifest committer support. It is not needed on the classpath
+ except when using this committer, so it only tagged as
+ "provided".
+ -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
Review comment:
scope "provided" means used to compile but not included in the
dependency list of the published artifact
*there are no new runtime dependencies unless you want to use the manifest
committer*
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -219,6 +219,58 @@
<scope>test</scope>
</dependency>
+ <!--
+ the mapreduce-client-core module is compiled against for the
+ manifest committer support. It is not needed on the classpath
+ except when using this committer, so it only tagged as
+ "provided".
+ -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>test</scope>
+ <type>test-jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
Review comment:
scope is test only. we have lots of other test scope only dependencies
already and it is not an issue
note also the hadoop-azure-test jar will not publish any of its transitive
dependencies at all. so nobody will notice. which is good as we already pull in
things like distcp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 741539)
Time Spent: 34h 20m (was: 34h 10m)
> Add a task-manifest output committer for Azure and GCS
> ------------------------------------------------------
>
> Key: MAPREDUCE-7341
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7341
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: client
> Affects Versions: 3.3.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 34h 20m
> Remaining Estimate: 0h
>
> Add a task-manifest output committer for Azure and GCS
> The S3A committers are very popular in Spark on S3, as they are both correct
> and fast.
> The classic FileOutputCommitter v1 and v2 algorithms are all that is
> available for Azure ABFS and Google GCS, and they have limitations.
> The v2 algorithm isn't safe in the presence of failed task attempt commits,
> so we
> recommend the v1 algorithm for Azure. But that is slow because it
> sequentially lists
> then renames files and directories, one-by-one. The latencies of list
> and rename make things slow.
> Google GCS lacks the atomic directory rename required for v1 correctness;
> v2 can be used (which doesn't have the job commit performance limitations),
> but it's not safe.
> Proposed
> * Add a new FileOutputFormat committer which uses an intermediate manifest to
> pass the list of files created by a TA to the job committer.
> * Job committer to parallelise reading these task manifests and submit all the
> rename operations into a pool of worker threads. (also: mkdir, directory
> deletions on cleanup)
> * Use the committer plugin mechanism added for s3a to make this the default
> committer for ABFS
> (i.e. no need to make any changes to FileOutputCommitter)
> * Add lots of IOStatistics instrumentation + logging of operations in the
> JobCommit
> for visibility of where delays are occurring.
> * Reuse the S3A committer _SUCCESS JSON structure to publish IOStats & other
> data
> for testing/support.
> This committer will be faster than the V1 algorithm because of the
> parallelisation, and
> because a manifest written by create-and-rename will be exclusive to a single
> task
> attempt, delivers the isolation which the v2 committer lacks.
> This is not an attempt to do an iceberg/hudi/delta-lake style manifest-only
> format
> for describing the contents of a table; the final output is still a directory
> tree
> which must be scanned during query planning.
> As such the format is still suboptimal for cloud storage -but at least we
> will have
> faster job execution during the commit phases.
>
> Note: this will also work on HDFS, where again, it should be faster than
> the v1 committer. However the target is very much Spark with ABFS and GCS; no
> plans to worry about MR as that simplifies the challenge of dealing with job
> restart (i.e. you don't have to)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
