[
https://issues.apache.org/jira/browse/MAPREDUCE-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szilard Nemeth updated MAPREDUCE-7379:
--------------------------------------
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
> RMContainerRequestor#makeRemoteRequest has confusing log message
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-7379
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7379
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Ashutosh Gupta
> Priority: Trivial
> Labels: newbie, newbie++, pull-request-available
> Fix For: 3.4.0
>
> Attachments: YARN-9355.001.patch, YARN-9355.002.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor#makeRemoteRequest
> has this log:
> {code:java}
> if (ask.size() > 0 || release.size() > 0) {
> LOG.info("getResources() for " + applicationId + ":" + " ask="
> + ask.size() + " release= " + release.size() + " newContainers="
> + allocateResponse.getAllocatedContainers().size()
> + " finishedContainers=" + numCompletedContainers
> + " resourcelimit=" + availableResources + " knownNMs="
> + clusterNmCount);
> }
> {code}
> The reason why "getResources()" is printed because
> org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator#getResources
> invokes makeRemoteRequest. This is not too informative and error-prone as
> name of getResources could change over time and the log will be outdated.
> Moreover, it's not a good idea to print a method name from a method below the
> current one in the stack.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
