[
https://issues.apache.org/jira/browse/MAPREDUCE-7370?focusedWorklogId=784305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784305
]
ASF GitHub Bot logged work on MAPREDUCE-7370:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 16:35
Start Date: 23/Jun/22 16:35
Worklog Time Spent: 10m
Work Description: steveloughran commented on code in PR #4248:
URL: https://github.com/apache/hadoop/pull/4248#discussion_r905241976
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/MultipleOutputs.java:
##########
@@ -570,8 +570,14 @@ public void setStatus(String status) {
*/
@SuppressWarnings("unchecked")
public void close() throws IOException, InterruptedException {
- for (RecordWriter writer : recordWriters.values()) {
- writer.close(context);
- }
+ recordWriters.values().parallelStream().forEach(writer -> {
Review Comment:
this is probably true. looking at IOUtils, our own cleanupWithLogger()
method catches all throwables, but closeSocket() only swallows IOEs. We must
assume a lot of other code is similar, so raised IOEs must stay as IOEs
Issue Time Tracking
-------------------
Worklog Id: (was: 784305)
Time Spent: 1.5h (was: 1h 20m)
> Parallelize MultipleOutputs#close call
> --------------------------------------
>
> Key: MAPREDUCE-7370
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7370
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 3.3.0
> Reporter: Prabhu Joseph
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This call takes more time when there are lot of files to close and there is a
> high latency to close. Parallelize MultipleOutputs#close call to improve the
> speed.
> {code}
> public void close() throws IOException {
> for (RecordWriter writer : recordWriters.values()) {
> writer.close(null);
> }
> }
> {code}
> Idea is from [[email protected]]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
