[
https://issues.apache.org/jira/browse/MAPREDUCE-7375?focusedWorklogId=796163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796163
]
ASF GitHub Bot logged work on MAPREDUCE-7375:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/22 18:42
Start Date: 28/Jul/22 18:42
Worklog Time Spent: 10m
Work Description: cnauroth commented on code in PR #4237:
URL: https://github.com/apache/hadoop/pull/4237#discussion_r932562817
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmissionFiles.java:
##########
@@ -160,6 +160,7 @@ public static Path getStagingDir(Cluster cluster,
Configuration conf,
}
} catch (FileNotFoundException e) {
fs.mkdirs(stagingArea, new FsPermission(JOB_DIR_PERMISSION));
Review Comment:
I suggest using static method `FileSystem.mkdirs(fs, stagingArea, new
FsPermission(JOB_DIR_PERMISSION))`. It's one less line of code and potentially
one less remote call for certain `FileSystem` implementations.
Issue Time Tracking
-------------------
Worklog Id: (was: 796163)
Time Spent: 1h 50m (was: 1h 40m)
> JobSubmissionFiles don't set right permission after mkdirs
> ----------------------------------------------------------
>
> Key: MAPREDUCE-7375
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7375
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 3.3.2
> Reporter: Zhang Dongsheng
> Priority: Major
> Labels: pull-request-available
> Attachments: MAPREDUCE-7375.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> JobSubmissionFiles provide getStagingDir to get Staging Directory.If
> stagingArea missing, method will create new directory with this.
> {quote}fs.mkdirs(stagingArea, new FsPermission(JOB_DIR_PERMISSION));{quote}
> It seems create new directory with JOB_DIR_PERMISSION,but this permission
> will be apply by umask.If umask too strict , this permission may be 000(if
> umask is 700).So we should change permission after create.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
