[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630372#comment-17630372
 ] 

ASF GitHub Bot commented on MAPREDUCE-5608:
-------------------------------------------

aajisaka commented on code in PR #5014:
URL: https://github.com/apache/hadoop/pull/5014#discussion_r1016514206


##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java:
##########
@@ -577,6 +577,8 @@ public interface MRJobConfig {
   public static final String MAX_SHUFFLE_FETCH_HOST_FAILURES = 
"mapreduce.reduce.shuffle.max-host-failures";
   public static final int DEFAULT_MAX_SHUFFLE_FETCH_HOST_FAILURES = 5;
 
+  String SHUFFLE_INDEX_CACHE = "mapreduce.reduce.shuffle.indexcache.mb";

Review Comment:
   Could you make it static final?





> Replace and deprecate mapred.tasktracker.indexcache.mb
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-5608
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5608
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Ashutosh Gupta
>            Priority: Major
>              Labels: BB2015-05-TBR, configuration, newbie, 
> pull-request-available
>         Attachments: MAPREDUCE-5608-002.patch, MAPREDUCE-5608.003.patch, 
> MAPREDUCE-5608.patch
>
>
> In MR2 mapred.tasktracker.indexcache.mb still works for configuring the size 
> of the shuffle service index cache.  As the tasktracker no longer exists, we 
> should replace this with something like mapreduce.shuffle.indexcache.mb. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to