[ https://issues.apache.org/jira/browse/MAPREDUCE-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637123#comment-17637123 ]
ASF GitHub Bot commented on MAPREDUCE-7427: ------------------------------------------- skysiders opened a new pull request, #5157: URL: https://github.com/apache/hadoop/pull/5157 ### Description of PR When creating "history/done_intermediate", we seem to assume that the parent directory of the folder exists and has the correct permissions. But when I run it, it doesn't work. When the umask is too strict, the permission of the parent directory will be wrong. Even under the default umask, the permission of the parent directory cannot be guaranteed to be 777. This is because the "history/done_intermediate" directory needs to be accessed by mapred, and the user when the directory was created The group information is user1 and supergroup, so mapred will access it as other user. It can be seen that at the time of creation, only the permission setting of the last-level directory is concerned (setPermission will only take effect for the last-level path), and no permission is set for the parent path. In this patch, I have given permissions to its parent path through the stack ### How was this patch tested? Test for all parent directory permission. ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Parent directory permission could be wrong while create done_intermediate > directory > ----------------------------------------------------------------------------------- > > Key: MAPREDUCE-7427 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7427 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: jobhistoryserver > Affects Versions: 3.3.4 > Reporter: Zhang Dongsheng > Priority: Major > > When creating "history/done_intermediate", we seem to assume that the parent > directory of the folder exists and has the correct permissions. But when I > run it, it doesn't work. When the umask is too strict, the permission of the > parent directory will be wrong. Even under the default umask, the permission > of the parent directory cannot be guaranteed to be 777. This is because the > "history/done_intermediate" directory needs to be accessed by mapred, and the > user when the directory was created The group information is user1 and > supergroup, so mapred will access it as other user. It can be seen that at > the time of creation, only the permission setting of the last-level directory > is concerned (setPermission will only take effect for the last-level path), > and no permission is set for the parent path. In this patch, I have given > permissions to its parent path through the stack -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org