[
https://issues.apache.org/jira/browse/MAPREDUCE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715024#comment-17715024
]
Steve Loughran commented on MAPREDUCE-7437:
-------------------------------------------
{code}
Code Warning
ST Write to static field
org.apache.hadoop.mapreduce.task.reduce.Fetcher.nextId from instance method new
org.apache.hadoop.mapreduce.task.reduce.Fetcher(JobConf, TaskAttemptID,
ShuffleSchedulerImpl, MergeManager, Reporter, ShuffleClientMetrics,
ExceptionReporter, SecretKey)
Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details)
In class org.apache.hadoop.mapreduce.task.reduce.Fetcher
In method new org.apache.hadoop.mapreduce.task.reduce.Fetcher(JobConf,
TaskAttemptID, ShuffleSchedulerImpl, MergeManager, Reporter,
ShuffleClientMetrics, ExceptionReporter, SecretKey)
Field org.apache.hadoop.mapreduce.task.reduce.Fetcher.nextId
At Fetcher.java:[line 120]
{code}
> spotbugs complaining about .Fetcher's update of a nonatomic static counter
> --------------------------------------------------------------------------
>
> Key: MAPREDUCE-7437
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7437
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build, client
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
>
> I'm having to do this to get MAPREDUCE-7435 through the build; spotbugs is
> complaining about the Fetcher constructor incrementing a non-static shared
> counter. Which is true, just odd it has only just surfaced.
> going to fix as a standalone patch but include that in the commit chain of
> that PR too
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
