[
https://issues.apache.org/jira/browse/MAPREDUCE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768382#comment-17768382
]
ASF GitHub Bot commented on MAPREDUCE-7453:
-------------------------------------------
slfan1989 commented on code in PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#discussion_r1335173344
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java:
##########
@@ -58,20 +58,20 @@ public void testCommandLine() throws Exception {
app.verifyCompleted();
Assert.assertEquals(
- "[" + MRApps.crossPlatformify("JAVA_HOME") + "/bin/java" +
- " -Djava.net.preferIPv4Stack=true" +
- " -Dhadoop.metrics.log.level=WARN " +
- " -Xmx820m -Djava.io.tmpdir=" + MRApps.crossPlatformify("PWD") + "/tmp"
+
- " -Dlog4j.configuration=container-log4j.properties" +
- " -Dyarn.app.container.log.dir=<LOG_DIR>" +
- " -Dyarn.app.container.log.filesize=0" +
- " -Dhadoop.root.logger=INFO,CLA -Dhadoop.root.logfile=syslog" +
- " org.apache.hadoop.mapred.YarnChild 127.0.0.1" +
- " 54321" +
- " attempt_0_0000_m_000000_0" +
- " 0" +
- " 1><LOG_DIR>/stdout" +
- " 2><LOG_DIR>/stderr ]", app.launchCmdList.get(0));
+ "[" + MRApps.crossPlatformify("JAVA_HOME") + "/bin/java" +
Review Comment:
avoid space
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java:
##########
@@ -163,20 +163,20 @@ public void testCommandLineWithLog4JConifg() throws
Exception {
app.verifyCompleted();
Assert.assertEquals(
- "[" + MRApps.crossPlatformify("JAVA_HOME") + "/bin/java" +
- " -Djava.net.preferIPv4Stack=true" +
- " -Dhadoop.metrics.log.level=WARN " +
- " -Xmx820m <ADD_OPENS> -Djava.io.tmpdir=" +
MRApps.crossPlatformify("PWD") + "/tmp" +
- " -Dlog4j.configuration=" + testLogPropertieFile +
- " -Dyarn.app.container.log.dir=<LOG_DIR>" +
- " -Dyarn.app.container.log.filesize=0" +
- " -Dhadoop.root.logger=INFO,CLA -Dhadoop.root.logfile=syslog" +
- " org.apache.hadoop.mapred.YarnChild 127.0.0.1" +
- " 54321" +
- " attempt_0_0000_m_000000_0" +
- " 0" +
- " 1><LOG_DIR>/stdout" +
- " 2><LOG_DIR>/stderr ]", app.launchCmdList.get(0));
+ "[" + MRApps.crossPlatformify("JAVA_HOME") + "/bin/java" +
Review Comment:
avoid space
> Container logs are missing when yarn.app.container.log.filesize is set to
> default value 0.
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7453
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7453
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 3.3.6
> Reporter: zhengchenyu
> Assignee: zhengchenyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Since HADOOP-18649, in container-log4j.properties,
> log4j.appender.\{APPENDER}.MaxFileSize is set to
> ${yarn.app.container.log.filesize}, but yarn.app.container.log.filesize is 0
> in default. So log is missing. This log is always rolling and only show the
> latest log.
> This is the running log like below:
> {code:java}
> Log Type: syslog
> Log Upload Time: Fri Sep 08 11:36:09 +0800 2023
> Log Length: 0
> Log Type: syslog.1
> Log Upload Time: Fri Sep 08 11:36:09 +0800 2023
> Log Length: 179
> 2023-09-08 11:31:34,494 INFO [AsyncDispatcher event handler]
> org.apache.hadoop.yarn.util.RackResolver: Got an error when resolve
> hostNames. Falling back to /default-rack for all. {code}
> Note: log4j.appender.\{APPENDER}.MaxFileSize is not set before, then use
> default value 10M, so no problem before HADOOP-18649
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
