[ https://issues.apache.org/jira/browse/MAPREDUCE-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769840#comment-17769840 ]
ASF GitHub Bot commented on MAPREDUCE-7456: ------------------------------------------- p-szucs commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339288056 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ContainerLocalizer.java: ########## @@ -400,6 +403,13 @@ private LocalizerStatus createStatus() throws InterruptedException { public static List<String> getJavaOpts(Configuration conf) { String opts = conf.get(YarnConfiguration.NM_CONTAINER_LOCALIZER_JAVA_OPTS_KEY, YarnConfiguration.NM_CONTAINER_LOCALIZER_JAVA_OPTS_DEFAULT); + boolean isExtraJDK17OptionsConfigured = + conf.getBoolean(YarnConfiguration.NM_CONTAINER_LOCALIZER_JAVA_OPTS_ADD_EXPORTS_KEY, + YarnConfiguration.NM_CONTAINER_LOCALIZER_JAVA_OPTS_ADD_EXPORTS_DEFAULT); + Review Comment: Added test cases here as well. > Extend add-opens flag to container launch commands on JDK17 nodes > ----------------------------------------------------------------- > > Key: MAPREDUCE-7456 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7456 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Affects Versions: 3.4.0 > Reporter: Peter Szucs > Assignee: Peter Szucs > Priority: Major > Labels: pull-request-available > > There was a previous ticket for adding add-opens flag to container launch to > be able to run them on JDK17 nodes: > https://issues.apache.org/jira/browse/MAPREDUCE-7449 > As testing discovered, this should be extended with > "{_}-add-exports=java.base/sun.net.dns=ALL-UNNAMED{_}" and > "{_}-add-exports=java.base/sun.net.util=ALL-UNNAMED{_}" options to be able to > run containers on Isilon. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org