[ https://issues.apache.org/jira/browse/MAPREDUCE-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805702#comment-17805702 ]
ASF GitHub Bot commented on MAPREDUCE-7468: ------------------------------------------- hadoop-yetus commented on PR #6442: URL: https://github.com/apache/hadoop/pull/6442#issuecomment-1887565170 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 7m 34s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +0 :ok: | xmllint | 0m 0s | | xmllint was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ branch-3.3 Compile Tests _ | | +0 :ok: | mvndep | 13m 28s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 37m 26s | | branch-3.3 passed | | +1 :green_heart: | compile | 2m 12s | | branch-3.3 passed | | +1 :green_heart: | checkstyle | 0m 52s | | branch-3.3 passed | | +1 :green_heart: | mvnsite | 1m 25s | | branch-3.3 passed | | +1 :green_heart: | javadoc | 0m 59s | | branch-3.3 passed | | +1 :green_heart: | spotbugs | 2m 28s | | branch-3.3 passed | | +1 :green_heart: | shadedclient | 37m 17s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 15s | | the patch passed | | +1 :green_heart: | compile | 1m 59s | | the patch passed | | +1 :green_heart: | javac | 1m 59s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 0m 39s | [/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6442/1/artifact/out/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt) | hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 495 unchanged - 1 fixed = 496 total (was 496) | | +1 :green_heart: | mvnsite | 1m 11s | | the patch passed | | +1 :green_heart: | javadoc | 0m 40s | | the patch passed | | +1 :green_heart: | spotbugs | 2m 38s | | the patch passed | | +1 :green_heart: | shadedclient | 37m 55s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 48s | | hadoop-mapreduce-client-core in the patch passed. | | -1 :x: | unit | 8m 44s | [/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6442/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt) | hadoop-mapreduce-client-app in the patch passed. | | +1 :green_heart: | asflicense | 0m 35s | | The patch does not generate ASF License warnings. | | | | 171m 51s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.mapreduce.v2.app.job.impl.TestMapReduceChildJVM | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6442/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6442 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint | | uname | Linux 0f39a7d0b8dc 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.3 / 3c6a13354ce772fd557a6639becc8a9004258a99 | | Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6442/1/testReport/ | | Max. process+thread count | 1618 (vs. ulimit of 5500) | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6442/1/console | | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Change add-opens flag's default value from true to false > -------------------------------------------------------- > > Key: MAPREDUCE-7468 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7468 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 3.4.0, 3.3.7 > Reporter: Benjamin Teke > Assignee: Benjamin Teke > Priority: Major > Labels: pull-request-available > > To support avoid issues when a newer JobClient is used with Hadoop versions > without MAPREDUCE-7449 the default value of > mapreduce.jvm.add-opens-as-default should be false. Currently it's true, this > can cause if a newer JobClient is used to submit apps, as the placeholder > replacement won't happen during a container launch, resulting in a failed > submission. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org