[
https://issues.apache.org/jira/browse/MAPREDUCE-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842723#comment-17842723
]
ASF GitHub Bot commented on MAPREDUCE-7475:
-------------------------------------------
kaiyaok2 commented on PR #6785:
URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2088785314
> commented on one test, same issue with the other.
>
> * safest to deleteFully() at the start of the test, just before attempting
mkdirs()
> * otherwise, try/finally...but that doesn't recover from a jvm exit/crash
@steveloughran Thanks for the suggestions! I've made the changes accordingly.
> 2 tests are non-idempotent (passes in the first run but fails in repeated
> runs in the same JVM)
> -----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7475
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7475
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Environment: Ubuntu 22.04, Java 17
> Reporter: Kaiyao Ke
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> 2 tests are not idempotent and fails upon repeated execution within the same
> JVM instance due to self-induced state pollution. Specifically, these tests
> try to make the directory TEST_ROOT_DIR and write to it. The tests do not
> clean up (remove) the directory after execution. Therefore, in the second
> execution, TEST_ROOT_DIR would already exist and the exception `Could not
> create test dir` would be thrown. Below are the 2 non-idempotent tests:
> * org.apache.hadoop.mapred.TestOldCombinerGrouping.testCombiner
> * org.apache.hadoop.mapreduce.TestNewCombinerGrouping.testCombiner
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
