[
https://issues.apache.org/jira/browse/MAPREDUCE-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924162#comment-17924162
]
ASF GitHub Bot commented on MAPREDUCE-7418:
-------------------------------------------
cnauroth commented on code in PR #7350:
URL: https://github.com/apache/hadoop/pull/7350#discussion_r1943331285
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java:
##########
@@ -369,9 +369,15 @@ public void setup() {
if (httpScheme.equals(WebAppUtils.HTTPS_PREFIX)) {
String amKeystoreLoc = System.getenv("KEYSTORE_FILE_LOCATION");
+ if (StringUtils.isBlank(amKeystoreLoc)) {
Review Comment:
Why were changes needed in this file?
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/EnvironmentVariablesExtension.java:
##########
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.mapreduce.v2.app.webapp;
+
+import org.junit.contrib.java.lang.system.EnvironmentVariables;
+import org.junit.jupiter.api.extension.BeforeEachCallback;
+import org.junit.jupiter.api.extension.ExtensionContext;
+
+public class EnvironmentVariablesExtension implements BeforeEachCallback {
Review Comment:
Is this needed? I couldn't find it used anywhere else in the patch.
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app
> ---------------------------------------------------
>
> Key: MAPREDUCE-7418
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7418
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: test
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
