[
https://issues.apache.org/jira/browse/MAPREDUCE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925211#comment-17925211
]
ASF GitHub Bot commented on MAPREDUCE-7420:
-------------------------------------------
zhtttylz commented on PR #7363:
URL: https://github.com/apache/hadoop/pull/7363#issuecomment-2644938659
> > @slfan1989 , I entered a few minor comments.
> > I am really blown away by how fast we are moving through these JUnit
migrations thanks to the automated tooling. I can't imagine how long it would
take for us to convert all of these tests manually. You should be really proud
of this tool and look into open sourcing it more broadly!
>
> @cnauroth Thank you very much for your help in reviewing the code! I
believe the reason we were able to complete the unit test upgrades so quickly
is not only due to the help of the tools, but also because of your proactive
code reviews. I would also like to specially thank my colleague @zhtttylz, who
completed most of the development of the tool. It has truly been a helpful
tool, and after we finish upgrading the Hadoop unit tests, we plan to add it to
Hadoop-Tools and provide documentation. This way, if there is any future work,
such as upgrading from JUnit 5 to JUnit 6, we can handle it much more easily.
@cnauroth and @slfan1989, thank you both for your guidance and support
throughout the JUnit migration. Your thorough reviews and insights truly helped
us move forward efficiently, and I’m grateful for your expertise. I also
appreciate your feedback on the tool: although it still needs some refinement,
I’m glad it helped accelerate our work. We plan to provide a final version once
the Hadoop upgrade is complete, and I look forward to continuing our efforts
together. Thank you again!
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core
> ----------------------------------------------------
>
> Key: MAPREDUCE-7420
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7420
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: test
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]