[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031198#comment-18031198
 ] 

ASF GitHub Bot commented on MAPREDUCE-7522:
-------------------------------------------

hadoop-yetus commented on PR #8040:
URL: https://github.com/apache/hadoop/pull/8040#issuecomment-3422749745

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   7m 34s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 23s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |   1m 47s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  checkstyle  |   0m 52s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 11s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  5s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   1m 53s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | -1 :x: |  spotbugs  |   1m  7s | 
[/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/artifact/out/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-warnings.html)
 |  
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in 
trunk has 39 extant spotbugs warnings.  |
   | -1 :x: |  spotbugs  |   3m 55s | 
[/branch-spotbugs-hadoop-mapreduce-project-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/artifact/out/branch-spotbugs-hadoop-mapreduce-project-warnings.html)
 |  hadoop-mapreduce-project in trunk has 265 extant spotbugs warnings.  |
   | +1 :green_heart: |  shadedclient  |  28m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 36s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 36s |  |  the patch passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |   1m 36s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 37s |  |  the patch passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |   1m 37s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 42s | 
[/results-checkstyle-hadoop-mapreduce-project.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/artifact/out/results-checkstyle-hadoop-mapreduce-project.txt)
 |  hadoop-mapreduce-project: The patch generated 4 new + 713 unchanged - 5 
fixed = 717 total (was 718)  |
   | +1 :green_heart: |  mvnsite  |   1m 47s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 42s |  |  the patch passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   1m 36s |  |  the patch passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | -1 :x: |  spotbugs  |   1m 11s | 
[/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/artifact/out/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.html)
 |  
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
generated 5 new + 3 unchanged - 36 fixed = 8 total (was 39)  |
   | -1 :x: |  spotbugs  |   4m  3s | 
[/new-spotbugs-hadoop-mapreduce-project.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/artifact/out/new-spotbugs-hadoop-mapreduce-project.html)
 |  hadoop-mapreduce-project generated 5 new + 229 unchanged - 36 fixed = 234 
total (was 265)  |
   | +1 :green_heart: |  shadedclient  |  28m 34s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   8m  6s |  |  hadoop-mapreduce-client-app in 
the patch passed.  |
   | +1 :green_heart: |  unit  | 139m 16s |  |  hadoop-mapreduce-project in the 
patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 40s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 270m  8s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | 
module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
 |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:[line 2170] |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:[line 2171] |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl,
 Task)  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl,
 Task)  At JobImpl.java:[line 2065] |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl,
 JobEvent)  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl,
 JobEvent)  At JobImpl.java:[line 1980] |
   |  |  Unknown bug pattern AT_STALE_THREAD_WRITE_OF_PRIMITIVE in 
org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int)
  At 
RMContainerAllocator.java:org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int)
  At RMContainerAllocator.java:[line 1068] |
   | SpotBugs | module:hadoop-mapreduce-project |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:[line 2170] |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount()
  At JobImpl.java:[line 2171] |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl,
 Task)  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl,
 Task)  At JobImpl.java:[line 2065] |
   |  |  Increment of volatile field 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl,
 JobEvent)  At JobImpl.java:in 
org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl,
 JobEvent)  At JobImpl.java:[line 1980] |
   |  |  Unknown bug pattern AT_STALE_THREAD_WRITE_OF_PRIMITIVE in 
org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int)
  At 
RMContainerAllocator.java:org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int)
  At RMContainerAllocator.java:[line 1068] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.51 ServerAPI=1.51 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8040 |
   | Optional Tests | dupname asflicense codespell detsecrets xmllint compile 
javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle |
   | uname | Linux 26c594e2c00e 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 
00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / c139406400f01ea33e484cb1e21597c1912f831a |
   | Default Java | Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/testReport/ |
   | Max. process+thread count | 1623 (vs. ulimit of 5500) |
   | modules | C: 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
hadoop-mapreduce-project U: hadoop-mapreduce-project |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8040/3/console |
   | versions | git=2.25.1 maven=3.9.11 spotbugs=4.9.7 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Fix SpotBugs issues in hadoop-mapreduce-client-app module
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-7522
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7522
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mapreduce-client
>    Affects Versions: 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> The {{hadoop-mapreduce-client-app}} module currently reports several SpotBugs 
> warnings during static analysis. These warnings indicate potential issues 
> such as resource leaks, null pointer risks, and inefficient object usage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to