----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117401/#review55300 -----------------------------------------------------------
src/lib/marble/geodata/data/GeoDataVec2.cpp <https://git.reviewboard.kde.org/r/117401/#comment38518> GeoDataVec2 is derived from QPointF, so operator== should include checks for x() == other.x() && y() == other.y() src/lib/marble/geodata/data/GeoDataViewVolume.cpp <https://git.reviewboard.kde.org/r/117401/#comment38519> should also call equals(other) since it is derived from GeoDataObject - Dennis Nienhüser On April 6, 2014, 11:44 a.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117401/ > ----------------------------------------------------------- > > (Updated April 6, 2014, 11:44 a.m.) > > > Review request for Marble. > > > Bugs: 333116 > http://bugs.kde.org/show_bug.cgi?id=333116 > > > Repository: marble > > > Description > ------- > > - Added the definition for GeoDataGroundOverlay::setLatLonQuad(const > GeoDataLatLonQuad& quad) > - Added operator== and operator!= to the classes GeoDataViewVolume, > GeoDataVec2, GeoDataScreenOverlay, GeoDataPhotoOverlay and > GeoDataGroundOverlay > - Added a protected bool equals( const GeoDataOverlay &other ) const method > to GeoDataOverlay which is called in operator== of GeoDataScreenOverlay, > GeoDataPhotoOverlay and GeoDataGroundOverlay to avoid redundancy. > - Extended tests/TestEquality by a new unit test method for each of the > classes (except of GeoDataOverlay) which verifies the implementation for > several instances of each class. > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataGroundOverlay.h 2e144af > src/lib/marble/geodata/data/GeoDataGroundOverlay.cpp 0a87dc4 > src/lib/marble/geodata/data/GeoDataOverlay.h cbfa36a > src/lib/marble/geodata/data/GeoDataOverlay.cpp dd02665 > src/lib/marble/geodata/data/GeoDataPhotoOverlay.h d7bae96 > src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp b4baf39 > src/lib/marble/geodata/data/GeoDataScreenOverlay.h 084fb79 > src/lib/marble/geodata/data/GeoDataScreenOverlay.cpp 3fe3375 > src/lib/marble/geodata/data/GeoDataVec2.h 6676281 > src/lib/marble/geodata/data/GeoDataVec2.cpp d27415d > src/lib/marble/geodata/data/GeoDataViewVolume.h a138338 > src/lib/marble/geodata/data/GeoDataViewVolume.cpp 0ede2a8 > tests/TestEquality.cpp bf4ee53 > > Diff: https://git.reviewboard.kde.org/r/117401/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
