> On April 10, 2014, 1:09 p.m., Alexander Potashev wrote: > > This looks better, but the compilation problem you had also indicates that > > some local headers are missing some includes.
I agree, I'd rather keep local header includes on top and system libraries below and add includes to the local files as needed. Aleksei, can you please paste the original error somewhere? - Dennis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117476/#review55372 ----------------------------------------------------------- On April 10, 2014, 1:05 p.m., Aleksei Aleshin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117476/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 1:05 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Plugin build failed on Windows 8.1 with Visual Studio 2012 and Qt-5.2.1 x64. > Changing order of includes fixes it. > > > Diffs > ----- > > src/plugins/render/satellites/SatellitesTLEItem.cpp 45628ac > > Diff: https://git.reviewboard.kde.org/r/117476/diff/ > > > Testing > ------- > > > Thanks, > > Aleksei Aleshin > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
