-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117507/
-----------------------------------------------------------
Review request for Marble and Dennis Nienhüser.
Bugs: 300184
http://bugs.kde.org/show_bug.cgi?id=300184
Repository: marble
Description
-------
Task:
Currently the configuration of the earthquake plugin selects a time range that
defaults from somewhere in 2006 to the current date. This range is then stored
in the config and restored on the next start of Marble, but the current date
stays at the time of the first time it was opened. Therefore you only get a
display of recent earthquakes if you go to the plugin configuration dialog and
manually set the end time to the current time.
There are several ways to fix that:
- More intelligent saving of the end date that recognizes whether the end date
was overridden by the user
- Replacing the end datetime widget with a time range widget to choose a
duration instead
- Having a radio button / check box that does similar
Solution:
I chose the path of intelligent saving of the end date. If the user explicitly
sets the end date, so the date value will be saved. Otherwise If the user does
not set a value, so each plugin start will be sets the end date to current new
value.
Diffs
-----
src/plugins/render/earthquake/EarthquakeConfigWidget.ui 0cc1804
src/plugins/render/earthquake/EarthquakePlugin.h 1cb88b7
src/plugins/render/earthquake/EarthquakePlugin.cpp 47f041c
Diff: https://git.reviewboard.kde.org/r/117507/diff/
Testing
-------
Thanks,
Marek Hakala
_______________________________________________
Marble-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/marble-devel
