----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117980/#review57238 -----------------------------------------------------------
This review has been submitted with commit 2cded666997407cc3e12c15244e33e9c9cd7a769 by Cruceru Calin-Cristian to branch master. - Commit Hook On May 3, 2014, 10:41 p.m., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117980/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 10:41 p.m.) > > > Review request for Marble. > > > Bugs: 334276 > http://bugs.kde.org/show_bug.cgi?id=334276 > > > Repository: marble > > > Description > ------- > > - Added operator== and operator!= to the classes GeoDataSnippet and > GeoDataLookAt; > - Overrode the equals() method of GeoDataObject within GeoDataFeature; > - Added test cases for each of the methods implemented. > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataFeature.h 84cd281 > src/lib/marble/geodata/data/GeoDataFeature.cpp 7c87d6c > src/lib/marble/geodata/data/GeoDataLookAt.h 98b5bd9 > src/lib/marble/geodata/data/GeoDataLookAt.cpp c3e0aea > src/lib/marble/geodata/data/GeoDataSnippet.h 1ee9edd > src/lib/marble/geodata/data/GeoDataSnippet.cpp 8664618 > src/lib/marble/geodata/data/GeoDataTour.cpp 1a0bb5e > tests/TestEquality.cpp d9a6369 > > Diff: https://git.reviewboard.kde.org/r/117980/diff/ > > > Testing > ------- > > Tested with tests/TestEquality and it works fine. > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
