----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118009/#review57355 -----------------------------------------------------------
Ship it! Can you sharpen the wording slightly from "This branch is outdated" to "You are using the outdated and erroneus qt5 branch" and append another sentence "Both branches have support for Qt 5.x" at the end. Feel free to push that directly without updating the review request. - Dennis Nienhüser On May 5, 2014, 8:01 p.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118009/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 8:01 p.m.) > > > Review request for Marble. > > > Bugs: 333887 > http://bugs.kde.org/show_bug.cgi?id=333887 > > > Repository: marble > > > Description > ------- > > Added a cmake warning to CMakeLists.text that warns about the qt5 branch > being outdated and asks people to switch to master (development) or KDE/4.13 > (stable) > > > Diffs > ----- > > CMakeLists.txt ba40d82 > > Diff: https://git.reviewboard.kde.org/r/118009/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
