----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118380/#review58682 -----------------------------------------------------------
Ship it! Great, this approach is much nicer usability wise :-) src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118380/#comment40833> Please add a Q_UNUSED( option ); src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118380/#comment40834> Are the node type checks needed? I think you can just call m_listView->openPersistentEditor( index ); in any case here. src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118380/#comment40835> "Current map center" (no title capitalization, no colon at the end) src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118380/#comment40836> else create a new view (with a, say, new GeoDataLookAt) src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118380/#comment40837> can you use speaking names, e.g. m_radio_play, m_radio_pause? src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118380/#comment40838> I'd avoid the technical term URL and use something like "Audio location" - Dennis Nienhüser On May 28, 2014, 2:45 p.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118380/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 2:45 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch adds functionality for editing Tour items from the Tour Widget > > > Diffs > ----- > > src/lib/marble/TourWidget.h 103740b > src/lib/marble/TourWidget.cpp b94b307 > src/lib/marble/graphicsview/WidgetGraphicsItem.cpp 246e8fd > > Diff: https://git.reviewboard.kde.org/r/118380/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
