----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118720/#review59990 -----------------------------------------------------------
Can you elaborate a bit where the problem occurs and which effects it has? Renaming the methods like this implies that they're not used anywhere and can be removed altogether. I kind of doubt that, and instead would expect that some further changes would be needed which change setClipping() calls to setClipScreen() calls. - Dennis Nienhüser On June 13, 2014, 8:56 a.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118720/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 8:56 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > The current ClipPainter class overwrites some function of its base class > QPainter and because of this some QPainter clipping functions is working and > some not. With the renaming of some function, the original clipping method > works again, and the ClipPainter class works as it should too. > > > Diffs > ----- > > src/lib/marble/ClipPainter.h 67715c5 > src/lib/marble/ClipPainter.cpp 74765a4 > > Diff: https://git.reviewboard.kde.org/r/118720/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
