----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119003/#review61152 -----------------------------------------------------------
src/lib/marble/ParallelTrack.h <https://git.reviewboard.kde.org/r/119003/#comment42582> The name is misleading, should rather be something like balloonHidden() src/lib/marble/ParallelTrack.h <https://git.reviewboard.kde.org/r/119003/#comment42583> Since we also have a balloonHidden (aka placemarkPaused), this should rather be void balloonShown( GeoDataPlacemark* ); (other name, no bool parameter) src/lib/marble/PlaybackAnimatedUpdateItem.h <https://git.reviewboard.kde.org/r/119003/#comment42584> better call it rootDocument or findRootDocument src/lib/marble/PlaybackAnimatedUpdateItem.h <https://git.reviewboard.kde.org/r/119003/#comment42586> const QString & both rootDocument() and findPlacemark() should be private src/lib/marble/PlaybackAnimatedUpdateItem.cpp <https://git.reviewboard.kde.org/r/119003/#comment42587> bool visible src/lib/marble/PlaybackItem.h <https://git.reviewboard.kde.org/r/119003/#comment42588> balloonHidden, balloonShown, see above src/lib/marble/TourPlayback.h <https://git.reviewboard.kde.org/r/119003/#comment42589> showBalloon( GeoDataPlacemark* ) - Dennis Nienhüser On June 28, 2014, 7:32 p.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119003/ > ----------------------------------------------------------- > > (Updated June 28, 2014, 7:32 p.m.) > > > Review request for Marble, Dennis Nienhüser and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > This patch implements functionality to open/close placemark balloons during > tour playback. > If there is a TourControl item with value Pause, then the balloon disappears. > If there is a TourControl item with value Play, then tour resumes normally. > > > Diffs > ----- > > src/lib/marble/ParallelTrack.h fc57625 > src/lib/marble/ParallelTrack.cpp d6fa78f > src/lib/marble/PlaybackAnimatedUpdateItem.h 0555d60 > src/lib/marble/PlaybackAnimatedUpdateItem.cpp 03f3a97 > src/lib/marble/PlaybackFlyToItem.h 1d937e5 > src/lib/marble/PlaybackItem.h 780ea45 > src/lib/marble/TourPlayback.h 991ea43 > src/lib/marble/TourPlayback.cpp 5e62265 > src/lib/marble/layers/PopupLayer.cpp 0bc58cd > > Diff: https://git.reviewboard.kde.org/r/119003/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
