----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117188/ -----------------------------------------------------------
(Updated July 15, 2014, 7:07 p.m.) Review request for Marble, Dennis Nienhüser and Torsten Rahn. Changes ------- I have fixed the two tests which failed due to the commit 798be2a0c27a2058e497eb2409fbb38cf7148a22 . 1. First test, TestGeoDataWriter, was faling because : In KmlSimpleDataTagWriter and KmlSchemaDataTagWriter I was passing wrong namespace ( kml::kmlTag_nameSpace22 ) to static GeoTagWriterRegistrar s_writerSimpleData(...) . I just changed that to kml::kmlTag_nameSpaceOgc22 and it worked fine. 2. Sorry, I have been unable to put my point on why TestGeoDataTrack failed. So, I have written detailed descrption at http://paste.kde.org/pfetilhpe . Hope that helps. :) Repository: marble Description ------- Added support for kml tag SchemaData and its child element SimpleData. Diffs (updated) ----- src/lib/marble/geodata/data/GeoDataExtendedData.cpp 1fb41bd src/lib/marble/geodata/data/GeoDataSchemaData.h 4c444b0 src/lib/marble/geodata/data/GeoDataSchemaData.cpp c834c72 src/lib/marble/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp 616e6b9 src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.cpp 97d3acc src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.cpp 1f79f94 tests/data/schemaData.kml df01536 Diff: https://git.reviewboard.kde.org/r/117188/diff/ Testing ------- Works fine on my system Thanks, Abhinav Gangwar
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
