----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119317/#review62597 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On Juli 16, 2014, 1:23 nachm., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119317/ > ----------------------------------------------------------- > > (Updated Juli 16, 2014, 1:23 nachm.) > > > Review request for Marble, Dennis Nienhüser and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > This patch includes 2 changes: > - Annotate Plugin actions menu redesigned: > * The action group is now exclusive, so no more checking and no more > actions selected at the same time; > * I removed the 'Enable Moving Map' option since it does not have any > purpose yet. Also, from some reasons, it was not working properly: unchecking > and checking it again caused both annotate items and the map to catch the > events. > * I added a new action, 'Select item' which corresponds to the 'Editing' > state - when having this action selected, the user can move the > nodes/polygon, remove nodes, pop-up de Properties menu, etc (somehow it is > the equivalent of nothing being checked before making this group actions > exclusive). > - Added node highlighting on hovering events (mouse move events) in both > 'Editing' state and 'MergingNodesState'. Also, the cursor changes according > to these hovering events (please tell me if other cursors should be used - I > used the two ones you will see just for testing and they seemed to me the > most appropriate). > > PS: Testing with marble-qt provides a nicer interface owing to the toolbar > buttons. I recommend using marble-qt since this interface is closer to how > the final UI will be like than the KDE version (where the actions are only > within the View menu). > > > Diffs > ----- > > src/plugins/render/annotate/AnnotatePlugin.h 6f806c4 > src/plugins/render/annotate/AnnotatePlugin.cpp 6129b1a > src/plugins/render/annotate/AreaAnnotation.h f4f319a > src/plugins/render/annotate/AreaAnnotation.cpp b49d678 > src/plugins/render/annotate/GroundOverlayFrame.cpp 68fda48 > > Diff: https://git.reviewboard.kde.org/r/119317/diff/ > > > Testing > ------- > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
