----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119391/#review62974 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On Juli 21, 2014, 10:09 nachm., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119391/ > ----------------------------------------------------------- > > (Updated Juli 21, 2014, 10:09 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > As the title says, this patch includes changes for adding a small animation > when two nodes are being merged. Before, the merging was a little bit too > 'fast' and it could have confused the users. I think that this way, the > merging is much nicer. > > Also, you will see in this patch a couple of other small changes which I > decided to make after I discovered a couple of bugs. For example one could > not interact with the map anymore after selecting the second node to be > merged because in AnnotatePlugin, at each mouse press, the item got selected > for moving and deselected at mouse release, but when selecting the second > node to be merged, the release event was not caught by the item. > > I need your feedback regarding the way the new feature behaves :). > > > Diffs > ----- > > src/plugins/render/annotate/AreaAnnotation.cpp e0ed211 > src/plugins/render/annotate/CMakeLists.txt 4792a78 > src/plugins/render/annotate/EditPolygonDialog.cpp cc25874 > src/plugins/render/annotate/MergingNodesAnimation.h PRE-CREATION > src/plugins/render/annotate/MergingNodesAnimation.cpp PRE-CREATION > src/plugins/render/annotate/AnnotatePlugin.h 6bb9b61 > src/plugins/render/annotate/AnnotatePlugin.cpp dd403e6 > src/plugins/render/annotate/AreaAnnotation.h 6c305fe > > Diff: https://git.reviewboard.kde.org/r/119391/diff/ > > > Testing > ------- > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
