----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/#review63041 -----------------------------------------------------------
src/lib/marble/routing/RoutingWidget.h <https://git.reviewboard.kde.org/r/119448/#comment43765> initializeTour() (American English) src/lib/marble/routing/RoutingWidget.cpp <https://git.reviewboard.kde.org/r/119448/#comment43766> bool m_playing? For a state I'd rather expect an enum value, not a boolean. src/lib/marble/routing/RoutingWidget.cpp <https://git.reviewboard.kde.org/r/119448/#comment43767> I'd rather call it "Preview Tour" src/lib/marble/routing/RoutingWidget.cpp <https://git.reviewboard.kde.org/r/119448/#comment43768> Makes no sense to me here. src/lib/marble/routing/RoutingWidget.cpp <https://git.reviewboard.kde.org/r/119448/#comment43771> There is a memory leak here, someone needs to delete the tour when it's not needed anymore. - Dennis Nienhüser On July 24, 2014, 5:13 a.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119448/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 5:13 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch helps to view a route as a tour, by clicking on a toggled > Play/Pause button in the RoutingWidget when a route has been loaded > > > Diffs > ----- > > src/lib/marble/TourPlayback.cpp 6682322 > src/lib/marble/routing/RoutingWidget.h b0e6b6d > src/lib/marble/routing/RoutingWidget.cpp 7abee97 > > Diff: https://git.reviewboard.kde.org/r/119448/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
