----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119537/#review63562 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On Juli 29, 2014, 2:48 nachm., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119537/ > ----------------------------------------------------------- > > (Updated Juli 29, 2014, 2:48 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > I removed the bubble which popped up when clicking placemarks and I added a > new way to customize placemarks - an edit dialog. This has customizing > options for the following: > - link to the icon; > - placemark's coordinates; > - description; > - label color/scale; > - icon color/scale. > > The way it works is the following: just click the 'Add Placemark' action in > the View menu (or in the toolbar if you are running marble-qt) and a > placemark will automatically be added on the focus point on the map and the > dialog will show up. Then, if the 'Close' button is clicked, the placemark > which has just been added gets removed (it most probably means that the 'Add > placemark' button has been pressed by mistake). If the 'Ok' button is > pressed, the placemark gets saved. What is more, any change on dialog's > fields gets reflected on placemark's style/position immediately. I found this > behaviour nicer than the 'Apply' method which has been used on Polygon's edit > dialog and I'm planning to change that to be consistent with this one. If you > are ok with this, of course. > > There are, still, a couple of problems, which will take some time to deal > with, but are not very imperious. These are: > - the 'scale' field on both icon and label does not work at the moment. idis > told me that most probably the scale is not considered when rendering the > placemarks. I found a way to make it 'change something' (for label so far), > but I'm not sure if this is what should happen, it label becomes very > low-quality. See the attached patch. Please apply it after applying the main > patch and tell me what you think about it. What else should be modified so > that the label's text would become larger, not just zoomed (how it looks with > this patch). > - the color selector field for icon does nothing for the moment, simply > because I'm using GeoDataColorStyle::setColor() which when being called from > a GeoDataIconStyle instance does not actually affect the icon (the image) - > which in fact is obvious. There are a couple of options here. One would be to > create a couple of placemark icons, save them as .svg and implement a > mechanism to change their color (using QGraphicsSvgItem for example). > > I'm waiting feedback on the feature this patch adds as well as suggestions on > the issues I listed above. > > > Diffs > ----- > > src/plugins/render/annotate/EditGroundOverlayDialog.ui 8c88476 > src/plugins/render/annotate/EditTextAnnotationDialog.h PRE-CREATION > src/plugins/render/annotate/EditTextAnnotationDialog.cpp PRE-CREATION > src/plugins/render/annotate/EditTextAnnotationDialog.ui PRE-CREATION > src/plugins/render/annotate/PlacemarkTextAnnotation.h 733664b > src/plugins/render/annotate/PlacemarkTextAnnotation.cpp d56b8a6 > src/plugins/render/annotate/SceneGraphicsItem.h d9d5bfe > src/plugins/render/annotate/CMakeLists.txt b23ae06 > src/plugins/render/annotate/AnnotatePlugin.h 26e8483 > src/plugins/render/annotate/AnnotatePlugin.cpp 7e4b92f > > Diff: https://git.reviewboard.kde.org/r/119537/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Applying scale > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/29/bf82af3f-4b56-4f0b-8ab4-be680271aea9__Applying-scale.diff > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
