----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119354/#review63829 -----------------------------------------------------------
Torsten, any opinion? This seems like a very important fix to me. - Dennis Nienhüser On July 18, 2014, 10:14 a.m., Abhinav Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119354/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 10:14 a.m.) > > > Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel. > > > Repository: marble > > > Description > ------- > > I noticed some problem in rendering of colorize property in Atlas map . The > Atlas map from updated master shows all Asia and Europe colored with ice > colors. > > I figured out the problem why it's happening by comparing kml files ( > converted from ne_50m_land.shp ) converted using Marble's kml2kml tool and > Qgis. > > The problem was that the file I created using kml2kml was specifying the > geometry of a plcemark as MulltiGeometry ( containing only one polygon ) > while for exctly same placemark, in the kml file I converted using QGis, the > geometry was Polygon. > > This was due to the problem : > In ShpRunner, the case when shapeType is SHPT_POLYGON ,If there are more than > one linear rings, the placemark's geometry is set to Multigeometry ( even if > more than one linear rings represent a single polygon - one outer ring and > rest are inner rings ). > > Fix : > I fixed it by setting placemark's geometry to Multigeometry only when there > are more than one polygons ( more than one outer rings ). > i.e ( more than one linearring ) && ( more than one linearrings are > outerrings ). > > > Diffs > ----- > > src/plugins/runner/shp/ShpRunner.cpp 2e15688 > > Diff: https://git.reviewboard.kde.org/r/119354/diff/ > > > Testing > ------- > > Yes, patch works fine and fixes the problem. > > > Thanks, > > Abhinav Gangwar > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
