----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119633/#review63910 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On Aug. 6, 2014, 10:44 vorm., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119633/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 10:44 vorm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch adds GeoDataLineString::insert method. > Since all the others node-handling GeoDataLineString methods are just > wrappers over QVector methods, so is this insert method. I need this for > inserting nodes in a polyline (on which I'm working atm). Also, this would > ease the implementation of adding nodes to polygons as well since > GeoDataLinearRing inherits GeoDataLineString and uses the same methods for > handling nodes (at the moment the adding is done by shifting the nodes and > appending - but this is not possible for polylines). > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataLineString.h 58b4009 > src/lib/marble/geodata/data/GeoDataLineString.cpp 0a82f46 > > Diff: https://git.reviewboard.kde.org/r/119633/diff/ > > > Testing > ------- > > I even used it for adding nodes to polylines and works fine. > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
