----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119700/#review64201 -----------------------------------------------------------
src/lib/marble/MovieCapture.cpp <https://git.reviewboard.kde.org/r/119700/#comment44854> what about a call to QFile::remove( d->destinationFile ); src/lib/marble/TourCaptureDialog.cpp <https://git.reviewboard.kde.org/r/119700/#comment44857> tr() src/lib/marble/TourCaptureDialog.cpp <https://git.reviewboard.kde.org/r/119700/#comment44858> tr() src/lib/marble/TourCaptureDialog.cpp <https://git.reviewboard.kde.org/r/119700/#comment44856> tr() src/lib/marble/TourCaptureDialog.cpp <https://git.reviewboard.kde.org/r/119700/#comment44859> QString("<font color=\"red\">%1</font>").arg(tr("Video writing failed.")) Please move up inside the if (!m_writingPossible) { m_recorder->startRecording(); } block - Dennis Nienhüser On Aug. 10, 2014, 8:43 p.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119700/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2014, 8:43 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch allows cancelling of the recording of the tour while it is still > getting recorded, and cleans it up properly when the recording is cancelled > > > Diffs > ----- > > src/lib/marble/MovieCapture.h 33d7bd1 > src/lib/marble/MovieCapture.cpp 6146cf2 > src/lib/marble/TourCaptureDialog.h 7c7ed70 > src/lib/marble/TourCaptureDialog.cpp e82e9a1 > src/lib/marble/TourCaptureDialog.ui 86af32d > > Diff: https://git.reviewboard.kde.org/r/119700/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
