----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120013/#review65573 -----------------------------------------------------------
src/lib/marble/MapThemeManager.h <https://git.reviewboard.kde.org/r/120013/#comment45834> Please use a forward declaration here src/lib/marble/MapThemeManager.h <https://git.reviewboard.kde.org/r/120013/#comment45833> When reading "containing the informations for the process" I wonder what those might be. Please either mention that its description(), name() and iconFile() are used, or leave out that comment completely. src/lib/marble/MapThemeManager.cpp <https://git.reviewboard.kde.org/r/120013/#comment45830> I'd call it createMapThemeFromOverlay src/lib/marble/MapThemeManager.cpp <https://git.reviewboard.kde.org/r/120013/#comment45831> please use a QFileInfo to extract the information you need: suffix(), fileName(), absoluteFilePath() http://qt-project.org/doc/qt-4.8/qfileinfo.html src/lib/marble/MapThemeManager.cpp <https://git.reviewboard.kde.org/r/120013/#comment45832> please rename gridProperty src/lib/marble/MarbleModel.h <https://git.reviewboard.kde.org/r/120013/#comment45829> let's call it setMapTheme - Dennis Nienhüser On Aug. 31, 2014, 10:04 a.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120013/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2014, 10:04 a.m.) > > > Review request for Marble and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > This patch contains the code to create GeoSceneDocument from a > GeoDataPhotoOverlay, and a modification which enables to MarbleModel to use a > preset GeoSceneDocument. > > > Diffs > ----- > > src/lib/marble/MapThemeManager.h d18c8de6ec29153e00d079a4b30579ca1d9be14d > src/lib/marble/MapThemeManager.cpp 725cc44614073b2ee114a448ce08254ceffa4f5d > src/lib/marble/MarbleModel.h 9643186b62429a4e04f421030d64b8ab86cd7f7c > src/lib/marble/MarbleModel.cpp 5f1b88ae1ed4d19562ff8f7b3f0783a98f691685 > > Diff: https://git.reviewboard.kde.org/r/120013/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
