----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109379/ -----------------------------------------------------------
(Updated Oct. 11, 2014, 4:05 p.m.) Status ------ This change has been marked as submitted. Review request for Marble and Bernhard Beschow. Repository: marble Description ------- Changes to the elevation profile plugin, it's now possible to display the height profile for a GPX-track opened from file. I made a new classes for a) providing the data, one for routes and one for tracks. They are in the same file, should this be split into multiple files? b) the contextmenu, because it has some members which would only clutter ElevationProfileFloatItem. It is a friend class, is this ok? Comments please :) Diffs ----- src/plugins/render/elevationprofilefloatitem/CMakeLists.txt 872e5e1 src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.cpp PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h cb3bff1 src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp 0cbf307 src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.h PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.cpp PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.h PRE-CREATION src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/109379/diff/ Testing ------- Thanks, Roman Karlstetter
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
