----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121362/ -----------------------------------------------------------
(Updated Dec. 5, 2014, 11:34 p.m.) Review request for Marble, Dennis Nienhüser and Torsten Rahn. Changes ------- + use of qDeleteAll from QtAlgorithms (Thanks, tackat!) Repository: marble Description (updated) ------- Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5790648552652800 Valgrind detected a memory leak for approx 2k bytes in GeometryLayerPrivate::createGraphicsItemFromGeometry() function. That method adds newly created GeoGraphicsItem to the GeoGraphicsScene instance, which doesn't take care of newly created object. I tweaked code a bit so it cleans all items added. Leak has been neutralized. Diffs (updated) ----- src/lib/marble/GeoGraphicsScene.cpp 390d868 Diff: https://git.reviewboard.kde.org/r/121362/diff/ Testing ------- Double valgrind-check (inb4 the fix and after) Thanks, Illya Kovalevskyy
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
