----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121385/#review71533 -----------------------------------------------------------
src/plugins/render/measure/MeasureToolPlugin.h <https://git.reviewboard.kde.org/r/121385/#comment49886> This variable and the following ones should not be class members, but local variables in the method they're used. - Dennis Nienhüser On Dec. 7, 2014, 8:45 p.m., Popov Sergey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121385/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 8:45 p.m.) > > > Review request for Marble and Dennis Nienhüser. > > > Repository: marble > > > Description > ------- > > Related GCI-2014 task: > http://www.google-melange.com/gci/task/view/google/gci2014/6074427645100032 > > The first part of adding a feature. It shouldn't be submitted to the > repository unless the follow-up-tasks are completed. > > > Diffs > ----- > > src/plugins/render/measure/MeasureConfigWidget.ui d412fcb > src/plugins/render/measure/MeasureToolPlugin.h 2c2c27b > src/plugins/render/measure/MeasureToolPlugin.cpp 689c8b1 > > Diff: https://git.reviewboard.kde.org/r/121385/diff/ > > > Testing > ------- > > Qt and KDE Linux builds. > > > Thanks, > > Popov Sergey > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
