----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121540/#review72362 -----------------------------------------------------------
While I like the idea of moving the annotation plugin actions into a panel, I think QDockWidget creation does not belong in RenderPlugin. Our RenderPlugins are very much tied to Desktop-Marble already (see the attempt of integrating them into Marble Touch), so adding another QWidget dependency makes the situation even worse. In addition, I believe that the Annotation Plugin should only be a temporary appearance since it has various design issues. It really doesn't make sense for the plugin to implement its own way of rendering geometries rather than using GeoDataTreeModel. This doesn't only create several inconsistencies but also complicates porting to OpenGL. Moreover, why doesn't Marble allow editing of any user-loaded document right in FileViewWidget? So if the plugin's code was merged into the core we didn't need to pollute the RenderPlugin API even further. Perhaps we can come up with GCI tasks for merging the Annotation Plugin into the core step by step. This needs brainstorming and detailed planning, however. How shall we proceed here? - Bernhard Beschow On Dez. 15, 2014, 9:43 nachm., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121540/ > ----------------------------------------------------------- > > (Updated Dez. 15, 2014, 9:43 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Move annotation plugin actions into an "Edit Maps" panel > Also, now it's possible to add QDockWidgets to window from plugins. > GCI task: > http://www.google-melange.com/gci/task/view/google/gci2014/5809396621770752 > > > Diffs > ----- > > src/apps/marble-ui/ControlView.h 5cb75a5 > src/apps/marble-ui/ControlView.cpp 04657fc > src/lib/marble/RenderPlugin.h 67472fa > src/lib/marble/RenderPlugin.cpp 1f2e9b1 > src/plugins/render/annotate/AnnotatePlugin.h 96e966f > src/plugins/render/annotate/AnnotatePlugin.cpp 263448c > > Diff: https://git.reviewboard.kde.org/r/121540/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/233847c3-cd95-44bd-8df5-def5d74ba243__annotate.png > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
