> On Dez. 28, 2014, 3:48 nachm., Bernhard Beschow wrote: > > src/lib/marble/GeoDataTreeModel.h, line 103 > > <https://git.reviewboard.kde.org/r/121713/diff/2/?file=336208#file336208line103> > > > > What's the purpose of these methods? Why not implement them in the Tour > > classes to keep GeoDataTreeModel agnostic about tours? > > Mihail Ivchenko wrote: > It's necessary to call beginInsertRows/endInsertRows/etc (which are > protected) while inserting primitives into playlist, etc. So, IMHO, it's > better to add methods to work with TourPrimitives than make public methods > for calling beginInsertRows/etc
Looking at https://developers.google.com/kml/documentation/kmlreference (GeoData)TourPrimitives are regular (GeoData)Objects - similar to (GeoData)Features. Adding them to the (GeoData)Document and taking them into account for the GeoDataTreeModel looks like a sensible change to me. - Torsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121713/#review72605 ----------------------------------------------------------- On Dez. 28, 2014, 3:37 nachm., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121713/ > ----------------------------------------------------------- > > (Updated Dez. 28, 2014, 3:37 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > GCI task: > http://www.google-melange.com/gci/task/view/google/gci2014/5837060422238208 > > > Diffs > ----- > > src/lib/marble/GeoDataTreeModel.h 8fcdde8 > src/lib/marble/GeoDataTreeModel.cpp 0e7e037 > src/lib/marble/TourWidget.cpp 11a00e2 > src/lib/marble/layers/GeometryLayer.cpp 6b2bb60 > > Diff: https://git.reviewboard.kde.org/r/121713/diff/ > > > Testing > ------- > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
