----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121925/#review73506 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On Jan. 8, 2015, 3:32 nachm., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121925/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 3:32 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > GCI task: > http://www.google-melange.com/gci/task/view/google/gci2014/5805500734111744 > This patch fixes wrong behavior: > > During line 44 QXmlStreamReader::readElementText was called. > It calls readNext while it doesn't read EndElement or error happens. > So, after calling readElementText() usually we'll be at EndElement > And then, we calls "isCDATA()" which makes "return d->type == > QXmlStreamReader::Characters && d->isCDATA;", > but current type is not characters but endElement. > So, it always returns false in this case > > > Diffs > ----- > > src/lib/marble/geodata/handlers/kml/KmlDescriptionTagHandler.cpp 56f8918 > > Diff: https://git.reviewboard.kde.org/r/121925/diff/ > > > Testing > ------- > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
